[PATCH] Prevent the configure script to fail if CFLAGS="-Werror" is specified



Hello,

this is my first patch for GTK+, I hope this is the proper place to send
it, please forgive me if I am wrong :-)


Without the patch, configure fails with this error (in config.log):

configure:23638: checking if <X11/extensions/XIproto.h> is needed for xReply
configure:23651: gcc -c -DGDK_PIXBUF_DISABLE_DEPRECATED -Werror -Wall  -DG_DISABLE_SINGLE_INCLUDES -DATK_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES   conftest.c >&5
cc1: warnings being treated as errors
conftest.c: In function 'main':
conftest.c:73: error: unused variable 'rep'
configure:23651: $? = 1


Have the possibility to specify CFLAGS="-Werror" is very helpful to spot
easier other warnings.

Cheers,
Giuseppe



>From 506ab703aa2d57bbe3847dc0603685f4226dac2b Mon Sep 17 00:00:00 2001
From: Giuseppe Scrivano <gscrivano gnu org>
Date: Mon, 12 Apr 2010 15:04:36 +0200
Subject: [PATCH] Prevent the configure script to fail if CFLAGS="-Werror" is specified

---
 configure.in |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/configure.in b/configure.in
index d18b2f0..c8095f8 100644
--- a/configure.in
+++ b/configure.in
@@ -1408,12 +1408,14 @@ if test "x$gdktarget" = "xx11"; then
   # Check for xReply
 
   AC_MSG_CHECKING([if <X11/extensions/XIproto.h> is needed for xReply])
-  AC_TRY_COMPILE([#include <X11/Xlibint.h>],
-      [xReply *rep;],
+  AC_TRY_COMPILE([#include <X11/Xlibint.h>
+xReply *rep () {return NULL;}],
+      [rep ();],
       [AC_MSG_RESULT([no])],
       [AC_TRY_COMPILE([#include <X11/extensions/XIproto.h>
-#include <X11/Xlibint.h>],
-           [xReply *rep;],
+#include <X11/Xlibint.h>
+xReply *rep () {return NULL;}],
+           [rep ();]
            [AC_MSG_RESULT([yes])
             AC_DEFINE([NEED_XIPROTO_H_FOR_XREPLY], 1,
                       [Define if <X11/extensions/XIproto.h> needed for xReply])],
-- 
1.7.0.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]