Re: GtkSpreadTable ('spread-table' branch)

[Murray Cumming <murrayc murrayc com>]

On Fri, 2010-10-22 at 12:01 +0100, Emmanuele Bassi wrote:
> On Fri, 2010-10-22 at 12:53 +0200, Murray Cumming wrote:
> 
> > > > I am ready to add this to libegg, but it seems to depend on GTK+ 2 only 
> > > > right now, so do we want GTK+ 3 code there? If so, should I update 
> > > > everything to use GTK+ 3, make GTK+ 2/3 support selectable at configure 
> > > > time or simply dump the code in a subdirectory with a separate Makefile 
> > > > (much like wrapbox is currently)?
> > > 
> > > libegg components are meant to be copy and pasted into other projects;
> > > adding a dependency on gtk+-3 just for the spread-table is not a problem
> > > at all. just add a conditional like the ones currently there for
> > > different versions of gtk+-2.0, and recurse into the spread-table
> > > directory if gtk+-3.0 is available.
> > 
> > Wouldn't it be enough just to branch it and make master use only GTK+ 3?
> > Or is it used by so many projects that try to support both GTK+ 2 and 3
> > in the same branch (which seems increasingly painful)?
> 
> I think that the branch already happened - I see a gnome-2-32 branch in
> libegg;

Yes, that was me, not waiting before asking first. Bad me.

>  but it would probably require to port all components to gtk+-3
> if we want to make libegg a gtk+-3.0-only copy-and-paste library.

Yes, I'm suggesting that David does that.

-- 
murrayc murrayc com
www.murrayc.com
www.openismus.com