Re: rendering-cleanup-next

[John Ralls <jralls ceridwen us>]

On Sep 12, 2010, at 9:54 PM, Havoc Pennington wrote:

> Hi,
> 
> On Mon, Sep 13, 2010 at 12:05 AM, John Ralls <jralls ceridwen us> wrote:
>>> Could also  make it a gdk_x11 api.
>>> But maybe a hint that is a no-op on other backends is better.
>> 
>> I'm in favor of keeping platform-specific stuff in platform-specific files and directories, but that's in large part just because I'm a bit compulsive when it comes to code organization.
>> 
> 
> Making it gdk_x11 doesn't keep the platform-specific in
> platform-specific files. It would make all files touched by
> d3802ca8331ab09fe752407577b12d1525b5d89e now include gdkx.h and an
> #ifdef'd call to the gdk_x11 API. So textview, layout, treeview,
> viewport would all now have x11-specific code.
> 
> The API need not be X specific, though the details depend on how
> Windows and Mac work and I don't know them.
> 
> /**
> * gdk_window_set_clears_background:
> * @window: a #GdkWindow
> * @value: #TRUE to clear window to its background when damage occurs
> *

Sure, so the declaration goes in gdkwindow.h and the implementation in x11/gtkwindow-x11.c with no-op stubs in quartz/gdkwindow-quartz.c and win32/gdkwindow-win32.c.  I don't think the problem you're attacking actually occurs on quartz, so a no-op stub there should be fine. I don't know about Win32.

Regards,
John Ralls