Re: Bug 658098 - no way to specify optional domain field in gvfs password dialog

[Michal Suchanek <hramrach centrum cz>]

On 8 September 2011 12:47, Alberto Ruiz <aruiz gnome org> wrote:
> Why are you changing the value of HAS_DOMAIN ?
> -  G_ASK_PASSWORD_NEED_DOMAIN         = (1 << 2),
> +  G_ASK_PASSWORD_HAS_DOMAIN          = (1 << 2),
>    G_ASK_PASSWORD_SAVING_SUPPORTED    = (1 << 3),
> -  G_ASK_PASSWORD_ANONYMOUS_SUPPORTED = (1 << 4)
> +  G_ASK_PASSWORD_ANONYMOUS_SUPPORTED = (1 << 4),
> +  G_ASK_PASSWORD_NEED_DOMAIN         = (1 << 5)
>  } GAskPasswordFlags;

I am changing the value of NEED_DOMAIN because it's used incorrectly anyway.

Of course, the HAS_DOMAIN can be simply added.

If there are any cases when domain is actually needed then this change
may cause the dialog to be submitted without a domain when glib and
gtk (or whatever) is out of sync.

Thanks

Michal