Re: [PATCH] Fix 'make check' when the system glib is older than 2.34

[Simon McVittie <simon mcvittie collabora co uk>]

On 29/11/12 01:58, Vinicius Costa Gomes wrote:
> [PATCH] Fix 'make check' when the system glib is older than 2.34

Open a bug?

Which OS is this on, what configure options did you use, and which
version are your pkg-config and libtool?

>  noinst_PROGRAMS  = $(TEST_PROGS)
> -LDADD = ../libgobject-2.0.la $(top_builddir)/gthread/libgthread-2.0.la $(top_builddir)/glib/libglib-2.0.la
> +LDADD = $(top_builddir)/gthread/libgthread-2.0.la $(top_builddir)/glib/libglib-2.0.la ../libgobject-2.0.la

This is somewhat consistent with GStreamer's advice:

<http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/random/moving-plugins#n72>
>  - should list libs and cflags in stack order, with lowest in the
>    stack first (so one can link against highest in the stack
>    somewhere else without picking up everything from the somewhere
>    else)
>    e.g. $(GST_PLUGINS_BASE_CFLAGS) \
>         $(GST_BASE_CFLAGS) \
>         $(GST_CFLAGS) $(CAIRO_CFLAGS)

(strictly following GStreamer's advice would result in linking libglib,
then libgthread, then libgobject.)