Re: [PATCH] Fix 'make check' when the system glib is older than 2.34

[Vinícius Costa Gomes <vcgomes gmail com>]

Hi Simon,

On Thu, Nov 29, 2012 at 9:27 AM, Simon McVittie
<simon mcvittie collabora co uk> wrote:
>
> On 29/11/12 01:58, Vinicius Costa Gomes wrote:
> > [PATCH] Fix 'make check' when the system glib is older than 2.34
>
> Open a bug?

https://bugzilla.gnome.org/show_bug.cgi?id=689282

In the bug, I added more information about how I came to that patch.

>
> Which OS is this on, what configure options did you use, and which
> version are your pkg-config and libtool?

This happens on Linux (Exherbo) 3.6.5, pkg-config 0.27.1, libtool
2.4.2. I was compiling with the provided 'autogen.sh' (so without any
configure options).

>
> >  noinst_PROGRAMS  = $(TEST_PROGS)
> > -LDADD = ../libgobject-2.0.la $(top_builddir)/gthread/libgthread-2.0.la $(top_builddir)/glib/libglib-2.0.la
> > +LDADD = $(top_builddir)/gthread/libgthread-2.0.la $(top_builddir)/glib/libglib-2.0.la ../libgobject-2.0.la
>
> This is somewhat consistent with GStreamer's advice:
>
> <http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/random/moving-plugins#n72>
> >  - should list libs and cflags in stack order, with lowest in the
> >    stack first (so one can link against highest in the stack
> >    somewhere else without picking up everything from the somewhere
> >    else)
> >    e.g. $(GST_PLUGINS_BASE_CFLAGS) \
> >         $(GST_BASE_CFLAGS) \
> >         $(GST_CFLAGS) $(CAIRO_CFLAGS)
>
> (strictly following GStreamer's advice would result in linking libglib,
> then libgthread, then libgobject.)

Update the patch with this new order?

> _______________________________________________
> gtk-devel-list mailing list
> gtk-devel-list gnome org
> https://mail.gnome.org/mailman/listinfo/gtk-devel-list



Cheers,
--
Vinicius