Re: Composite GtkBuilder template

[Federico Mena Quintero <federico gnome org>]

On Thu, 2013-04-11 at 17:49 -0500, Federico Mena Quintero wrote:

> I'll do something like this.  First, revert the commit.  Then, merge my
> branch.  Doing a straight rebase is not trivial, as places-sidebar has
> gotten master merged into it a few times to keep up with general
> development.  And finally, apply your commit again with lots of changes.

So I went ahead and did this.  I learned why you don't support binding
widgets to fields in public structures (it's done on the class private
structure).

I refactored your patch to use priv->foo instead of impl->priv->foo
everywhere, and it is much nicer that way.  I may end up doing this to
gtk-2-24 as well for consistency.

Tristan, the composite templates stuff is *excellent* work.  The file
chooser's code is much cleaner now that all the silly widgetry is
editable in Glade!

I guess the next thing would be to have GtkPlacesSidebar set up its
internal GtkTreeView using Glade.  I'll investigate that later, but if
you already have a good pattern for doing this... :)

Thanks for this massively useful work - doing megawidgets in Glade is
really nice this way.

  Federico