Re: foo-doc.{top,bottom}

[Owen Taylor <otaylor redhat com>]

Damon Chaplin <damon ximian com> writes:

> Owen Taylor wrote:
> > 
> > The generation of these files was removed in the big commit of
> > 23 Jan. This breaks various makefiles - if it is intentional,
> > I can fix up the makefiles. If not, can I apply the following?
> > 
> > Thanks,
> >                                         Owen
> > 
> > Index: gtkdoc-mkdb.in
> > ===================================================================
> > RCS file: /cvs/gnome/gtk-doc/gtkdoc-mkdb.in,v
> > retrieving revision 1.23
> > diff -u -r1.23 gtkdoc-mkdb.in
> > --- gtkdoc-mkdb.in      2001/03/26 21:27:14     1.23
> > +++ gtkdoc-mkdb.in      2001/04/12 21:07:29
> > @@ -330,7 +330,7 @@
> >      }
> >      close (INPUT);
> > 
> > -    return $changed;
> > +    &OutputBook ($book_top, $book_bottom) || $changed;
> >  }
> > 
> > 
> > @@ -1098,7 +1098,7 @@
> >      print OUTPUT $book_top;
> >      close (OUTPUT);
> > 
> > -    &UpdateFileIfChanged ($old_file, $new_file, 0);
> > +    my $changed = &UpdateFileIfChanged ($old_file, $new_file, 0);
> > 
> > 
> >      $old_file = "$SGML_OUTPUT_DIR/$MODULE-doc.bottom";
> > @@ -1109,7 +1109,7 @@
> >      print OUTPUT $book_bottom;
> >      close (OUTPUT);
> > 
> > -    &UpdateFileIfChanged ($old_file, $new_file, 0);
> > +    &UpdateFileIfChanged ($old_file, $new_file, 0) || $changed;
> >  }
> 
> 
> I don't know how I managed to delete the call to &OutputBook().
> That should go back in.
> 
> Though I don't think the foo-doc.{top,bottom} files should affect
> the $changed flag (i.e. the timestamp). They are only output to
> help the author create the main SGML file when setting up the docs.
> I don't think they have any affect on the HTML.

Yes, you are right. (though I don't think they will change without
the resulting SGML changing, so it doesn't matter yet.)

And I also agree that there is not much point in distributing these
files.

Regards,
                                        Owen