Re: patch-review

[David Nečas (Yeti) <yeti physics muni cz>]

On Fri, Aug 10, 2007 at 08:30:09PM +0300, Stefan Kost wrote:
> > = .types file
> > gtkdoc-scan with --rebuild-types can recreate a types file. Problems:
> > * contains also the _get_types for enums (I belive gtkdoc-scanobj is now smart
> > enough to not introspect those).
> > * projects should use --ignore-headers to skip disabled modules.
> > * it misses the #includes - are they needed ?
> 
> yes, they are:
> 
> bt-core-scan.c: In function 'main':
> bt-core-scan.c:134: warning: implicit declaration of function 'gst_init'
> Compilation of scanner failed:

gst_init() is not a get_type() function, how it got there?

If the package needs to execute some other code for the
get_type() functions to work, then yes, auto-generated types
cannot be used.  More precisely, they can be used if one can
specify the startup code somewhere.  But I'm afraid this
gets us into an area where people may want so disparate and
weird things that assuming they will customize gtk-doc.make
anyway is a safe bet...

It seems you cannot reasonably use --rebuild-types, so is
this still about (not) putting this option into the stock
(modern) makefile or am I completely lost?

Note I'm fine with --rebuild-types not present in the stock
makefile, but things (cleaning, making dists, dependencies)
must not break when one adds

SCAN_OPTIONS = --rebuild-types

Yeti

--
http://gwyddion.net/