Re: patch-review

[Stefan Kost <ensonic hora-obscura de>]

Hi,

David Nečas (Yeti) wrote:
> On Fri, Aug 10, 2007 at 08:30:09PM +0300, Stefan Kost wrote:
>>> = .types file
>>> gtkdoc-scan with --rebuild-types can recreate a types file. Problems:
>>> * contains also the _get_types for enums (I belive gtkdoc-scanobj is now smart
>>> enough to not introspect those).
>>> * projects should use --ignore-headers to skip disabled modules.
>>> * it misses the #includes - are they needed ?
>> yes, they are:
>>
>> bt-core-scan.c: In function 'main':
>> bt-core-scan.c:134: warning: implicit declaration of function 'gst_init'
>> Compilation of scanner failed:
> 
> gst_init() is not a get_type() function, how it got there?
> 
> If the package needs to execute some other code for the
> get_type() functions to work, then yes, auto-generated types
> cannot be used.  More precisely, they can be used if one can
> specify the startup code somewhere.  But I'm afraid this
> gets us into an area where people may want so disparate and
> weird things that assuming they will customize gtk-doc.make
> anyway is a safe bet...

The issue is that probably lots of libs need to call some foreign init. If I
e.g. don't do that for gst_init (gstreamer) that all my gstreamer subclassed
types would show up as gobjects.

Stefan