Re: API "break" request

[Murray Cumming <murrayc murrayc com>]

On Wed, 2005-02-09 at 00:47 +0000, Gustavo J. A. M. Carneiro wrote:
>   I'm sorry to come this late ask for an API change,

gnome-python, right?

>  but I've just
> discovered[1].  Apparently rescanning header files and merging .defs
> again for libgnomeui caused an accidental rename of
> gnome.ui.Client.connect_to_session_manager (gnome-python 2.6.x) to
> gnome.ui.Client.connect (2.9.x).

Consider this a bug fix for an API break (during the unstable phase)
that should not have happened. I don't think you need approval.

>   This is change was accidentally and may break existing gnome-python
> applications.  Moreover, the overloading of connect() in gnome.ui.Client
> and gobject.GObject causes major confusion for developers.
> 
>   The following patch fix it.  There's no danger to "rush" the API here,
> I just want to use the old and tested API.
> 
>   Regards.
> 
> 
> --- gnome/ui.defs       16 Jan 2005 01:05:17 -0000      1.15
> +++ gnome/ui.defs       9 Feb 2005 00:42:58 -0000
> @@ -1419,7 +1419,7 @@
>    (return-type "GnomeClient*")
> )
> 
> -(define-method connect
> +(define-method connect_to_session_manager

This does not look like the best way to rename methods in gnome-python.
The .defs should describe the API that you wrap, not the wrapper API.
Maybe ui_overrides.defs would be useful. I'd bet that your system could
handle reading a second file, replacing stuff that it finds.

>    (of-object "GnomeClient")
>    (c-name "gnome_client_connect")
>    (return-type "none")
> 
> 
> 
> [1] http://oss.codepoet.no/bugzilla/show_bug.cgi?id=117

-- 
Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com