Re: [Nautilus-list] eel compilation problem

[Trevor Nichols <ocdi ocdi org>]

Hi,

After removing the #include, I just checked it again, and no build error
this time.  I'm not sure what's different now from before, it seems rather
odd.

The previous erros I had were related to the eel-type-builtins-evals.c
file, I should have stored those errors as I can't reproduce it.  I guess
you can disregard the patch then.

-Trev.

On Wed, 18 Apr 2001, Ramiro Estrugo wrote:

> Actually, the up-to-date CVS version is ok.  I dont think this is a real
> build problem.  Tinderbox is green.
>
> A few people on #nautilus (tigert for one) have reported the same
> problem.
>
> I think that the problem is build dependency which nautilus hackers that
> user maintainer mode dont see.  Thats probably everyone.
>
> Heres my theory of why this is happening.
>
> A few days ago, Maciej changed eel to automatically generated gtk
> enumerations for all C enums defined in any eel header.
>
> Now, the code that populates the enumerations  - eel-types.c and
> eel-type-builtins-evals.c (included from eel-types.c) have a dependency
> on the header in question.  In this case eel-dnd.h which Darin changed
> yesterday.
>
> So the problem is that the auto generated eel-type-builtins-evals.c
> doesnt have a proper dependency on the headers that are used to generate
> it - even if a little indirectly because of the way makeenums.pl works.
>
> Im not sure why this works with maintainer mode but not otherwise.
>
> How to fix it ?  Anyone have ideas ?  Maybe its as simple as appending
> $(eel_headers) to the dependency list for eel-type-builtins-evals.c (and
> maybe the other auto generated files) ?
>
> Maybe the autogenerated .c files should be compiled instead of being
> #included from eel-types.c ?  Probably not the way makeenums.pl is
> designed to work.
>
> -re
>
> Trevor Nichols wrote:
> >
> > Hi,
> >
> > Here's a quick patch that I needed to fix the eel to compile for me. (just
> > need to include eel-dnd.h).  If anoncvs is out of date again and this is
> > already fixed, disregard this. :)
> >
> > -Trev
> >
> > Index: eel/eel.h
> > ===================================================================
> > RCS file: /cvs/gnome/eel/eel/eel.h,v
> > retrieving revision 1.3
> > diff -u -r1.3 eel.h
> > --- eel/eel.h   2001/04/17 20:49:19     1.3
> > +++ eel/eel.h   2001/04/18 12:48:12
> > @@ -33,6 +33,7 @@
> >  #include <eel/eel-clickable-image.h>
> >  #include <eel/eel-clist.h>
> >  #include <eel/eel-ctree.h>
> > +#include <eel/eel-dnd.h>
> >  #include <eel/eel-ellipsizing-label.h>
> >  #include <eel/eel-enumeration.h>
> >  #include <eel/eel-font-manager.h>
> >
> > _______________________________________________
> > Nautilus-list mailing list
> > Nautilus-list lists eazel com
> > http://lists.eazel.com/mailman/listinfo/nautilus-list
>
>