Re: [Nautilus-list] XALF patch

[Rémi Cohen-Scali <Remi Cohen-Scali com>]

Darin Adler wrote:

> > -            nautilus_launch_application_from_command ("",
> > +            nautilus_launch_application_from_command (name,
>
> A nice improvement here, but not mentioned in your change log entry.
Yes, I forgot this specific one.

> > -            command = uri + strlen (NAUTILUS_COMMAND_SPECIFIER);
> > -            eel_gnome_shell_execute (command);
> > +            name = nautilus_file_get_uri (file);
> > +            df = nautilus_desktop_file_new ();
> > +            nautilus_desktop_file_load (name, &df);
> > +            g_free (name);
> > +            nautilus_desktop_file_launch (df);
> > +            nautilus_desktop_file_free (df);
>
> This looks like the wrong part of the file to modify. This is only used when
> processing a "command:" URL. How did you test this? I think you didn't fix
> the case you meant to fix.
>
>    -- Darin
My goal is to have launch feedback when a desktop icon is clicked and a 
'command:' URL from a .desktop file is about to be executed.
On the nautilus-gnome-1 branch I'am testing it is one of the last xalf 
interaction that is missing if the NAUTILUS_USE_XALF environment 
variable is set.

Is there a difference between desktop icons (the subject of the first 
message in this topic) & urls with 'command:' scheme in desktop icons ?
I mean when a desktop icon is activated, the actual command comes from 
the 'command:....' builded from the 'Exec: ...' line of the desktop file.
No ?

Where do you think it should go ?

--
                                                         -o)
                  Remi Cohen-Scali                       /\\
<Remi Cohen-Scali com>          <rcoscali rcsnet net>    _\_v
                                                        ----