Re: [GNOME VFS] Patch for bug 74189

[Damon Chaplin <damon ximian com>]

On Tue, 2002-06-25 at 19:17, Ian McKellar wrote:
> On Tue, 2002-06-25 at 11:50, Damon Chaplin wrote:
> > 
> > Hi, I've attach a patch to this bug:
> > 
> >    http://bugzilla.gnome.org/show_bug.cgi?id=74189
> > 
> > 
> > gnome_vfs_async_job_cancel_job_and_callbacks() doesn't set the job's
> > cancelled flag to TRUE if async_job_callback_map == NULL. It just
> > returns.
> > 
> > So if a job is cancelled before any callbacks have been registered at
> > all, then it isn't marked as cancelled.
> >
> Looks pretty good to me - I don't know that code too well, but it looks
> like it'll fix that problem as its been described to me. Have you tested
> it a fair bit? Do you think we should try to get it approved for the 2.0
> release?

Too late for 2.0 :)

I could reproduce the crash by adding a sleep() in the right place, and
my patch fixed that. And nautilus seems OK otherwise.

Damon