Re: [Nautilus-list] [PATCH] location bar autocompletion



On Tue, 2002-02-26 at 08:46, Darin Adler wrote:
> The idea was that it would set some kind of flag to tell the event-after
> callback that the key wasn't handled. I figured you'd connect before to set
> a flag to say "event handled", connect after to clear the flag for the case
> where it wasn't, and connect to "event-after" to do the work in the case
> where the event was hanlded.

This is a reasonable idea, but I'd not do it if we don't have to.

> > Since I am still unclear on exactly what the "return_value == FALSE" is
> > comprised of (I've only seen it occur with things like, for ex.,
> > Gdk_Shift and this case is properly handled by the
> > entry_would_have_inserted_characters () function), the attached patch
> > only connects to event-after.
> 
> It's true that we ended up having to second guess GtkEntry anyway. Perhaps
> you're right and there's no particular key we'll handle wrong. Just make
> sure that you try all the keys on your keyboard, and that will cover most
> everything I hope. Please try that.

I think I got complete coverage, but I will look into GtkEntry later to
see if I can spot any corner cases.

In the mean time I'm going to go ahead and commit this; if it becomes a
problem I can probably fix it within a day or so and at the very least
this code is more functional than the current code....





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]