[Nautilus-list] http://bugzilla.gnome.org/show_bug.cgi?id=75172



Final patch to fix that bug.
It patches
1) using freed memory
2) double freeing memory
? 75172.patch
? 75222.patch
? hardware_view.png
? nautilus.patch
? schema
? components/mine
? libnautilus-private/.nautilus-mime-actions.c.swp
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/nautilus/ChangeLog,v
retrieving revision 1.5172
diff -u -w -r1.5172 ChangeLog
--- ChangeLog	29 Mar 2002 17:57:02 -0000	1.5172
+++ ChangeLog	30 Mar 2002 07:47:12 -0000
@@ -1,3 +1,10 @@
+2002-03-30  Jody Goldberg <jody gnome org>
+
+	* libnautilus-private/nautilus-mime-actions.c
+	(nautilus_mime_set_short_list_components_for_file) : Don't free the
+	  objects while we're still looking at their iids.  Don't double free
+	  the iids.
+
 2002-03-29  Jody Goldberg <jody gnome org>
 
 	* libnautilus-private/nautilus-program-chooser.c
Index: libnautilus-private/nautilus-mime-actions.c
===================================================================
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-mime-actions.c,v
retrieving revision 1.97
diff -u -w -r1.97 nautilus-mime-actions.c
--- libnautilus-private/nautilus-mime-actions.c	6 Mar 2002 19:24:43 -0000	1.97
+++ libnautilus-private/nautilus-mime-actions.c	30 Mar 2002 07:47:14 -0000
@@ -966,14 +966,13 @@
 		normal_short_list_ids = g_list_prepend (normal_short_list_ids, ((Bonobo_ServerInfo *) p->data)->iid);
 	}
 
-	gnome_vfs_mime_component_list_free (normal_short_list);
-
 	/* compute delta */
 
 	add_list = str_list_difference (components, normal_short_list_ids);
 	remove_list = str_list_difference (normal_short_list_ids, components);
 
-	eel_g_list_free_deep (normal_short_list_ids);
+	gnome_vfs_mime_component_list_free (normal_short_list);
+	g_list_free (normal_short_list_ids);
 
 	nautilus_file_set_metadata_list 
 		(file,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]