Re: [PATCH] gnome-vfs: Don't monitor read-only filesystems
- From: Alexander Larsson <alexl redhat com>
- To: "Manuel Amador (Rudd-O)" <amadorm usm edu ec>
- Cc: Sriram Ramkrishna <sri aracnet com>, Frederic Crozat <fcrozat mandrakesoft com>, Nautilus <nautilus-list gnome org>
- Subject: Re: [PATCH] gnome-vfs: Don't monitor read-only filesystems
- Date: 13 Apr 2004 15:58:22 +0200
On Thu, 2004-04-08 at 19:51, Manuel Amador (Rudd-O) wrote:
> El mié, 07-04-2004 a las 12:20, Alexander Larsson escribió:
> > On Wed, 2004-04-07 at 19:09, Sriram Ramkrishna wrote:
> > > On Wed, Apr 07, 2004 at 12:08:37PM +0200, Frederic Crozat wrote:
> > > > No, killing fam was enough.. Fam was maintaining an open fd on the cdrom
> > > > drive. Killing it allows unmounting the drive.
> > > >
> > >
> > > Fam needs to be a little smarter about this. For instance, if there
> > > was some way that it knows that an unmount request was sent to one
> > > of it's open fd it should try to release it. Or cdroms and usb storage
> > > devices should be handled specially..
> >
> > This is the wrong solution. We should have a file notification kernel
> > api that doesn't force you to have an open fd. And that doesn't totally
> > suck ass.
>
> Not quite, Alex. Suppose I try to unmount a volume, and at the same
> time FAM polls() a file on that volume. Bang, the same error, only it
> now appears intermittent and much harder to debug.
>
> This is exactly what happens when dnotify usage is disabled in FAM,
> which would amount to not using a file notif. kernel api.
Now, suppose dnotify didn't suck total ass. Suppose it didn't need
signals, and suppose it didn't need an open fd on the directory. BAM!
Instant client-side (without fam) monitoring without holding up
unmounts!
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson Red Hat, Inc
alexl redhat com alla lysator liu se
He's an underprivileged soccer-playing gangster She's a brilliant Buddhist
opera singer who don't take no shit from nobody. They fight crime!
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]