Re: [PATCH] Neaten up the layout for text beside icons

[Vincent Noel <vincent noel gmail com>]

Has this patch been applied ?
It enhances *a lot* the text-besides-icon experience, and could fix a
couple of bugs.
Cheers
Vincent



On Fri, 8 Oct 2004 12:09:35 +0100, Iain * <iaingnome gmail com> wrote:
> I had a thought about this last night, and decided that to get the
> grid layout to be neat and to use the most possible space is to set
> the gridsize to the size of the largest icon.
> 
> Attached is the patch to implement this. There's also some other fixes
> to my earlier one, that was causing bad layout in tight layout mode.
> It also removes an unused line of code.
> 
> The only case I can foresee that this will not look so good, is where
> the user has one or two really HUGE icons (> 2 times the width of the
> rest of the icons), but this is a very rare case, and if we do want to
> solve that, then we just need to check if icons could fit into factors
> of grid_size. but I don't think its necessary.
> 
> This also makes grid layout in text-under-icons mode neater too.
> 
> iain
> 
> 
> 
> On Thu, 7 Oct 2004 23:10:51 +0100, Iain * <iaingnome gmail com> wrote:
> > The reason the second screenshot it messed up is because the icon
> > width is just greater than 160 pixels and so it is aligned to the
> > second column, at 320 pixels. This was the case I explained as case b
> > in my earlier mail
> >
> > "b) when the icon's width is actually just over 210 pixels, in which
> > case the icon gets allocated 420 pixels (the next multiple of the grid
> > size) and so in the case of say an icon being 215 pixels wide, you end
> > up with 205 pixels blank space."
> >
> > There really isn't any solution for this, as to align the text to the
> > first columns baseline[1] would mean that part of the icon isn't going
> > to be on screen. I'm not sure if there's a fix for this, its a
> > limitation of having icons of variable sizes.
> >
> > iain
> > [1] I call it baseline, but really its a vertical line that runs from
> > the top of the column and has the icon on the left hand side, and the
> > text on the right.
> >
> > On Thu, 7 Oct 2004 13:13:13 -0400, Vincent Noel <vincent noel gmail com> wrote:
> >
> > > HOWEVER, while doing this I think I ran into the reason for the
> >
> >
> > > 210-pixels grid : thumbnails. If you set the grid size at 160 pixels,
> > > the alignment of thumbnails is screwed. See second screenshot.
> > >
> >
> 
> 
>