Re: Come fix bugs! (Batteries included)

[Alexander Larsson <alexl redhat com>]

On Wed, 2004-10-13 at 20:34 +0200, Danny Milosavljevic wrote:
> Am Mittwoch, den 13.10.2004, 20:23 +0200 schrieb Danny Milosavljevic:
> > Hi,
> > 
> > Am Mittwoch, den 13.10.2004, 17:21 +0200 schrieb Alexander Larsson:
> > > [...]
> > > On Tue, 2004-10-12 at 20:12 +0200, Danny Milosavljevic wrote:
> > > > [...]
> > > > Well as there seems to be a function to get the selection's coordinates
> > > > I'd like to try. Cant find the gtk_menu_popup call however. Help ? :)
> > > 
> > > Start from fm_directory_view_pop_up_selection_context_menu(). It gets
> > > all complicated with bonoboui stuff though. :(
> > 
> > eel's eel-gtk-extensions.c eel_pop_up_context_menu is called which in
> > turn calls gtk_menu_popup without callback but with data. uhm.... and
> > that data is a local variable that will go out of scope soon. That looks
> > so wrong.
> > 
> > But it seems to be the right place to mess with. 
> > 
> > the main work for determining the coordinates will go to 
> > nautilus fm-directory-view.c
> > fm_directory_view_pop_up_selection_context_menu
> > but the one that does the position callback is
> > eel's eel-gtk-extensions.c eel_pop_up_context_menu (after its fixed ;))
> > 
> > *tries*
> 
> Nope. Cant compile eel cvs. Sigh.
> 
> cc1: Warning: "-Wsign-promo" is valid for C++ but not for C/ObjC
> eel-background.c: In Funktion >>eel_background_ensure_realized<<:
> eel-background.c:733: Warnung: dereferencing type-punned pointer will
> break strict-aliasing rules
> make: *** [eel-background.lo] Error 1

Are you building from cvs? We should be automatically passing -Wno-
strict-aliasing if the compiler supports it to fix this issue.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an impetuous dishevelled gangster from a doomed world. She's an orphaned 
kleptomaniac archaeologist with only herself to blame. They fight crime!