Re: [PATCH] Bug 142227: alt-up should select folder in parent window

[Alexander Larsson <alexl redhat com>]

On Tue, 2004-10-19 at 08:59 -0700, Jimmy Do wrote:
> On Tue, 19 Oct 2004 15:55:18 +0200, Alexander Larsson <alexl redhat com> wrote:
> > > fm-directory-view.c (selection_changed_callback)
> > >       - reveal a new selection if it's set while the view is not loading
> > 
> > The patch in general looks good. I'm not sure I like this part though.
> > Is scrolling to the first selected item the best thing to do every time
> > the selection is changed from the shell? I don't think so. Better to
> > just do it in the cases where we know we want to.
> 
> Ok, that makes sense. How about this solution: Since we need to reveal
> the selection from nautilus-application.c
> (nautilus_application_present_spatial_window_with_selection), I'm
> thinking of creating a new function in nautilus-view-frame.c called
> 'nautilus_view_frame_reveal_selection'. So when a window is already
> open, we call nautilus_view_frame_selection_changed() and then
> nautilus_view_frame_reveal_selection() to reveal the new selection.
> Sound like a good idea?

Adding calls to the view is complicated, because that means changing the
corba IDL. You have to do changes like this by extending the view with
new interfaces. Fortunately we already have something for scrolling to a
file: nautilus_view_frame_scroll_to_file (). You can use that for this.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a bookish amnesiac messiah fleeing from a secret government programme. 
She's a sarcastic extravagent pearl diver who inherited a spooky stately manor 
from her late maiden aunt. They fight crime!