Re: [PATCH] Alert dialogs should not have window title according to the HIG



> On Do, 2005-12-15 at 20:57 -0800, Dennis Cranston wrote:
>> While using nautilus to copy a file to another directory, I was
>> presented with the attached
>> dialog.  "Conflict While Copying" should not be a button.  I believe
>> this bug was introduced when
>> the alert dialogs patch was applied to cvs.  Also, the window list
>> applet displayed a "untitled
>> window" button for the dialog.
>
> Yeah, blindly removing the title argument from the eel API wasn't a good
> idea, since it was a string and now is interpreted as part of the button
> label vararg. A bug report was also filed on this [1]. The attached
> patch (hopefully) fixes all the broken function calls.

Sorry I'm to blame for that.
Thanks for fixing it

Jaap




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]