Re: [PATCH] Alert dialogs should not have window title according to the HIG

[Dennis Cranston <dennis_cranston yahoo com>]

--- Jaap Haitsma <jaap haitsma org> wrote:

> > On Do, 2005-12-15 at 20:57 -0800, Dennis Cranston wrote:
> >> While using nautilus to copy a file to another directory, I was
> >> presented with the attached
> >> dialog.  "Conflict While Copying" should not be a button.  I believe
> >> this bug was introduced when
> >> the alert dialogs patch was applied to cvs.  Also, the window list
> >> applet displayed a "untitled
> >> window" button for the dialog.
> >
> > Yeah, blindly removing the title argument from the eel API wasn't a good
> > idea, since it was a string and now is interpreted as part of the button
> > label vararg. A bug report was also filed on this [1]. The attached
> > patch (hopefully) fixes all the broken function calls.
> 
> Sorry I'm to blame for that.
> Thanks for fixing it
> 
> Jaap

I have attached a one line fix for the "untitled window" button problem.

Dennis

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/eel/ChangeLog,v
retrieving revision 1.741
diff -u -p -r1.741 ChangeLog
--- ChangeLog	16 Dec 2005 20:49:11 -0000	1.741
+++ ChangeLog	17 Dec 2005 08:02:56 -0000
@@ -1,3 +1,8 @@
+2005-12-17  Dennis Cranston  <dennis_cranston yahoo com>
+
+	* eel/eel-alert-dialog.c:  Hide dialog from taskbar, so it
+	does not display "untitled window".
+	
 2005-12-13  Dennis Cranston  <dennis_cranston yahoo com>
 
 	* eel/eel-open-with-dialog.c: (eel_open_with_dialog_instance_init):
Index: eel/eel-alert-dialog.c
===================================================================
RCS file: /cvs/gnome/eel/eel/eel-alert-dialog.c,v
retrieving revision 1.5
diff -u -p -r1.5 eel-alert-dialog.c
--- eel/eel-alert-dialog.c	9 Dec 2005 12:05:08 -0000	1.5
+++ eel/eel-alert-dialog.c	17 Dec 2005 08:02:56 -0000
@@ -366,6 +366,7 @@ eel_alert_dialog_new (GtkWindow     *par
          * HIG says that alert dialogs should not have window title
          */
 	gtk_window_set_title (GTK_WINDOW (dialog), "");
+	gtk_window_set_skip_taskbar_hint (GTK_WINDOW (dialog), TRUE);
   	
 	eel_alert_dialog_set_primary_label (EEL_ALERT_DIALOG (dialog),
 	                                    primary_message);