Re: Bug #160348 - Use GtkAboutDialog

[Luca Ferretti <elle uca libero it>]

Il giorno gio, 20-01-2005 alle 09:47 +0100, Alexander Larsson ha
scritto:
> On Wed, 2005-01-19 at 14:23 +0100, Luca Ferretti wrote:
> > Il giorno mer, 19-01-2005 alle 12:41 +0100, Alexander Larsson ha
> > scritto:
> > > On Wed, 2005-01-19 at 08:36 +0100, Luca Ferretti wrote:
> > > > Could someone take a look here[1], tune the patch and eventually apply?
> > > 
> > > The documenters list looked ok, but I'm not sure exactly what to write
> > > for the copyright part. Each contributor owns copyright on what he
> > > writes.
> > > 
> > > I changed it to say:
> > > 
> > > Copyright © 2002-2005 Red Hat, Inc
> > > Copyright © 2002-2004 Novell, Inc
> > > Copyright © 1999-2001 Eazel, Inc.
> > > And all the other authors
> > 
> > A really long long list for a really small window.... Maybe we have to
> > open a bug against GtKAboutDialog suggesting a different layout for the
> > dialog. Stuff for Gtk+-2.8
> > 
> > BTW what about Licence? See Evince, but it could be better (for
> > translators) have a single place providing those strings instead the
> > same strings on every package.
> 
> Hmm, evince has "(c) The Evince Authors" maybe that is better for
> nautilus too. And we should probably add a license. Can you look into
> that?

Here is the patch. I didn't test it, but is based on Evince code. Just
removed \n on each line in licence[n] and s/\\n/\\n\\n in g_strconcat

But I've to open a bug against GTK+, to have something like

        ...
        "licence", GPL_LICENSE
        ...
        
to automatically build a similar text.

A lot of GTK+ projects are under GPL. IHMO is good to have a facility in
GTK+. Ad this is good for translators :-)

-- 
Luca Ferretti <elle uca libero it>

diff -Naur /usr/src/GNOME/CVS/nautilus/src/nautilus-window-menus.c nautilus/src/nautilus-window-menus.c
--- /usr/src/GNOME/CVS/nautilus/src/nautilus-window-menus.c	2005-01-20 11:56:36.000000000 +0100
+++ nautilus/src/nautilus-window-menus.c	2005-01-20 12:12:44.572368520 +0100
@@ -403,6 +403,23 @@
 		"Sun Microsystem",
 		NULL
 	};
+	const gchar *licence[] = {
+		N_("Nautilus is free software; you can redistribute it and/or modify "
+		   "it under the terms of the GNU General Public License as published by "
+		   "the Free Software Foundation; either version 2 of the License, or "
+		   "(at your option) any later version."),
+		N_("Nautilus is distributed in the hope that it will be useful, "
+		   "but WITHOUT ANY WARRANTY; without even the implied warranty of "
+		   "MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the "
+		   "GNU General Public License for more details."),
+		N_("You should have received a copy of the GNU General Public License "
+		   "along with Evince; if not, write to the Free Software Foundation, Inc., "
+		   "59 Temple Place, Suite 330, Boston, MA  02111-1307  USA")
+	};
+	gchar *license_trans;
+
+	license_trans = g_strconcat (_(licence[0]), "\n\n", _(license[1]), "\n\n",
+				     _(licence[2]), "\n", NULL);
 
 	if (about == NULL) {
  
@@ -420,10 +437,9 @@
 					   "for GNOME that makes it "
 					   "easy to manage your files "
 					   "and the rest of your system."),
-			      "copyright", _("Copyright \xC2\xA9 2002-2005 Red Hat, Inc\n"
-					     "Copyright \xC2\xA9 2002-2004 Novell, Inc\n"
-					     "Copyright \xC2\xA9 1999-2001 Eazel, Inc.\n"
-					     "And all the other authors"),
+			      "copyright", _("Copyright \xC2\xA9 1999-2005 "
+					     "The Nautilus authors"),
+			      "licence", licence_trans,
 			      "authors", authors,
 			      "documenters", documenters,
 			      "translator-credits", _("translator-credits"),