Re: patch nag: handle CORBA errors

[Alexander Larsson <alexl redhat com>]

On Thu, 2006-09-14 at 22:44 +0200, Christian Neumair wrote:
> Am Donnerstag, den 14.09.2006, 21:53 +0200 schrieb Alexander Larsson:
> > 
> > Is that really right? "!found || error != NULL" is the same as
> > "!(found
> > && error == NULL)", so we assert if we find something and get no
> > error?
> 
> Yes, that is right.

Ok. Makes sense then. Just checking.

> If you think it's worth switching over to that, I'm also all for it, but
> in the past some of my whitespace and mess-with-cvs-history patches were
> rejected, so I was/am a bit reluctant.

In general I don't think its a problem to fix up whitespace for a thing
you're changing. However, touching unrelated things with a whitespace
change makes for problems tracking history, so I'm not a huge fan of
them.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a lonely chivalrous cowboy on the wrong side of the law. She's a 
manipulative hip-hop archaeologist with an MBA from Harvard. They fight crime!