On 2/5/07, Alexander Larsson <alexl redhat com> wrote:
Still missing spaces in a few places like:
+gchar*
+get_trash_uri_for_volume(GnomeVFSVolume *volume)
and
+ if (gnome_vfs_volume_handles_trash(volume)) {
I think I got them all now :)
+ uri = 0; Use NULL here, not 0
Done.
get_trash_uri_for_volume(GnomeVFSVolume *volume): This function leaks vol_uri if there is no trash dir directory.
Moved the free outside the if
delete_callback(): The callback owns debuting_uris, so you must free it.
Done
You should ref volume/drive over delete callback to make sure it doesn't go away due to other reasons while showing the dialog.
Done Do you think this warrants a gconf option to disable the prompt? Jesse
Attachment:
nautilus-empty-trash-on-unmount.patch
Description: Binary data