Re: [PATCH] Nautilus location bar

[Alexander Larsson <alexl redhat com>]

On Sun, 2007-01-14 at 20:47 +0300, Виталий Ищенко wrote:
> В Вск, 14/01/2007 в 20:45 +0300, Виталий Ищенко пишет:
> > Slightly reworked GnomeVFS patch.
> > Now base == NULL checks are done later, when we actually start using it
> > So new function gnome_vfs_make_uri_from_input_with_base_internal behaves
> > absolutely the same way, as gnome_vfs_make_uri_from_input_internal,
> > except default case.
> 
> Forgot the patch

Yes, this looks like the right approach. However, I don't think you
should add a copy of gnome_vfs_make_uri_from_input_internal. Just make
it take a base argument and then pass NULL for base in the other uses of
it.

(Also, we're api frozen now unfortunately, so we can't add this to
gnome-vfs for 2.18...)

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an underprivileged soccer-playing photographer in drag. She's an 
enchanted junkie femme fatale with an MBA from Harvard. They fight crime!