Re: [rfc][patch] Add optional PackageKit hook to install new applications

[Alexander Larsson <alexl redhat com>]

On Thu, 2008-12-04 at 18:08 +0000, Richard Hughes wrote:
> On Thu, 2008-12-04 at 17:29 +0000, Kenneth MacDonald wrote:
> > On Thu, 2008-12-04 at 13:09 +0000, Richard Hughes wrote:
> > 
> > > Of course, an admin can switch off this functionality in
> > > gnome-packagekit, or I can even add a nautilus GConf key to not even
> > > show the question if you guys would prefer.
> > > 
> > > Comments appreciated.
> > 
> > Very cool, but we'd really want to be able to turn it off on e.g. lab
> > machines so a GConf key would be ideal.
> 
> Version 3 attached for review.

There are some coding style issues (no space before parenthesis, no
brackes around block).

You shouldn't have both a g_warning and a error dialog, in that case
drop the g_warning.

I agree that the dialog for no matching application when the gconf key
is off should not mention this. If its been turned off its because
someone wanted it off.

And finally, we don't generally use modal dialogs like that in nautilus.
Of course, this complicates things a bit, as if you do it non-modal then
ActivateParameters *parameters will be freed, so you need to keep some
info from it.