Re: [PATCH] Add compact icon view (column-wise)

[Christian Kirbach <christian kirbach googlemail com>]

On Sun, 17 Feb 2008 00:59:59 +0400, Christian Neumair <cneumair gnome org>  
wrote:

> I dediced to do some balancing computer hacking between two written
> tests. I'm attaching the results, namely a "compact icon view" - I'm not
> sure whether that name is verbose enough.

> Feedback appreciated.

Patch won't compile for me

fm-icon-view.c: In function 'fm_icon_view_real_get_directory_auto_layout':
fm-icon-view.c:898: error: 'view' undeclared (first use in this function)

I think you meant this

-	return fm_icon_view_is_compact (view) ||
+	return fm_icon_view_is_compact (icon_view) ||


First quick test run exhibits no flaws. Nice work.

Personally, I'd appreciate larger icons and text; sizes look pretty much
like list view to me. I believe we should be somewhere in between.

Regards


--
Christian Kirbach
Christian Kirbach googlemail com