Re: [Planner Dev] Testing group undo

["lincoln phipps openmutual net" <lincoln phipps openmutual net>]

> > tell me if I am wrong but I think you should not display the label of
> > the action to undo/redo within the undo/redo buttons. displaying it in
> > the tooltip seems sufficient, no (and why not in a popup menu beyond the
> > clicked undo/redo button)? 
>
>
> You are certainly not wrong, we just haven't figured out how to fix it
> :)

Looking at the code in planner-windows.c I see a label
is used for the tooltips and the gui. I knocked up an effective
cludge as shown below. I tried this and its much nicer not
having the buttons wobble around !.

Diff is...

Index: src/planner-window.c
===================================================================
RCS file: /cvs/gnome/planner/src/planner-window.c,v
retrieving revision 1.7
diff -u -b -B -p -r1.7 planner-window.c
--- src/planner-window.c	10 Feb 2004 05:29:44 -0000	1.7
+++ src/planner-window.c	14 Feb 2004 00:09:53 -0000
@@ -1137,7 +1137,7 @@ window_undo_state_changed_cb (PlannerCmd
 				      NULL);	
 	bonobo_ui_component_set_prop (priv->ui_component,
 				      "/commands/EditUndo",
-				      "label", label,
+				      "label", "Undo",
 				      NULL);
 }

@@ -1161,7 +1161,7 @@ window_redo_state_changed_cb (PlannerCmd
 				      NULL);	
 	bonobo_ui_component_set_prop (priv->ui_component,
 				      "/commands/EditRedo",
-				      "label", label,
+				      "label", "Redo",
 				      NULL);	
 }
===================================================================


Are translatable strings are automatically created in planner
i.e. the "Redo" and "Undo" will get marked for translation ?
This is one area I'm very hazy about.

Rgds,
Lincoln.



> It shouldn't be that hard o fix if someone wants to take a look. It
> would involve reading docs or code for libbonoboui and see what we do
> wrong.
>
> /Richard
>
> _______________________________________________
> Planner-dev mailing list
> Planner-dev lists imendio com
> http://lists.imendio.com/mailman/listinfo/planner-dev