Re: [Planner Dev] lag & more

["lincoln phipps openmutual net" <lincoln phipps openmutual net>]

Andrej Vodopivec wrote:
> Hi,
>
> I am new to planner but I like it a lot.
> I few things bother me and I am willing to give a hand in fixing them.
> I also have ideas on additional features but this I need to consider a bit
> and do more experimentation.
>
> The single thing that stands out is predecessor lag time.
> User guide says:
> "Finally, you can enter a lag time for the relationship, which 
> represents the
> number of days after the relationship has been satisfied."

Thats not right ! and its actually hours and not days; when you add
a link and set the lag then the value you add into the dialog is
actually an hourly figure, though its stored in the memory/xml
as a usual planner time i.e. in  seconds (1 in the dialog stored as 3600)

> To move the task in gantt window by a week one need to enter 7*24=168.
> I would expect this to be 5 (or whatever the calendar says about number of
> work days in the current week).
> Should I try to fix it or is somebody else is working on this. 

No one is working on it AFAIK - I'd raised a bugzilla for this,

http://bugzilla.gnome.org/show_bug.cgi?id=132357

which has some guidelines on what to look at.


Suppose
> it is
> me doing it, now, should I also fix the dialog to work like (not 
> implemented
> in planner 0.12) [Figure 17. Task properties dialog] in User guide were a
> default 'display time unit' can be selected (by the way I would like to 
> work
> using weeks to measure amount of work). I can also imagine lag being a 
> fixed
> value (not depandent on the calendar) as well. Any ideas?

Ideally we should remember how the user entered this delay, though store
it as seconds.

> Is there a quick start document for people willing to join the development
> effort of planner. Can I work by modifying 0.12 sources and file the 
> changes
> to somebody to be approved and entered into the main source body, ... ?

I was doing a quickstart but spent more time on actual patches so never
finished the quick start.

What to do this this,

Check out the CVS from anon (or live of you have a Gnome CVS account which not
everyone has). CVS is delayed by around a few hours or so from live so I check
the changelog at ,
http://cvs.gnome.org/viewcvs/planner/ChangeLog
with what I've checked out to see if I'm patching stale code. You can patch
stale code but at least check that the files you are changing have not been
changed by others (low risk but may happen).

Decide which branch you are working on - planner-0-12 or MAIN or new-sched
(Richard - can you advise here on this ?) The main issue at this time is
that the MAIN (and possibly new-sched) require quite new dependancies
which not many people have.

Patch the code (!) The editing rules are,

TAB is 8 spaces,
keep variables indented so  they align e.g.,
       gchar          *assigned_to;
       GList          *resources;
       MrpAssignment       *assignment;
       MrpResource    *resource

will be *rejected* (well not always if Richard is happy) as its slightly
out of alignment,

spaces after function name before the '('
and after commas in the function passed parameters e.g.,
	myfunc (MRP_RELATION_FS, 0, LINK_CASCADE,LINK_DOWN);
has a missing space after LINK_CASCADE,

No C++ comments i.e. no // (though when I code I actually add
	my notes as // style comments and then grep for them
	and then turn them into C comments or remove them if they
	don't really add much.

Don't go mad on comments ! When you start you end up commenting
every line as you learn about all the niceties of Planner and
then end up with overcommented code which Richard doesn't like.

Keep strings short (to help translators),
All strings are picked up for translation if they are defined like this
	
	_("your string here")


Keep curly bracket on the same line and code on the next line with the
closing curly bracket aligned to the operator e.g.,

for () {  <-- brace on the same line
  <-- code on the next line
}

Always use { } even for one-line blocks.

For copyright, you should add yourself to the files where you write
more than a few lines that aren't just copy/paste (quote from Richard),
Just append to existing copyright stuff at top,

CVS diff command used is,

	cvs diff -ubBp

(Cervisia will be patched to have this kind of option but I don't think
its ready yet so I use command line).

GLADE2 is only used to edit the .glade files - we don't compile those !.

enums should be namespaced, i.e. PLANNER_SOMETHING_SOMETHING, to
match the name of the type. We do this for everything that is used
not just inside of file (quote from Richard),

FREE FREE FREE (did I say FREE) ! always remember to free stuff because
this isn't Java ! After a while it gets easier to remember what needs
to be freed - usual strings, lists etc.

err thats about what I've learned so far ;).

Send the patch to the planner-dev list and Richard reviews this and
adds it to the code.

Anyone else to add to this - maybe we should add this is as a 1 page text
quickstart guide ? Welcome onboard.

Rgds,
Lincoln.

> Regards
> Andrej
> _______________________________________________
> Planner-dev mailing list
> Planner-dev lists imendio com
> http://lists.imendio.com/mailman/listinfo/planner-dev