Re: [Rhythmbox-devel] Rhythmbox Applet 0.1.0 Released



On Sun, Jul 25, 2004 at 10:11:52PM -0400, Jon Oberheide wrote:
>
> Hate to reply to my own email but...
> 
> When building the applet, it can't find Bonobo.idl or
> Bonobo_Property.idl when running orbit-idl-2.  My Bonobo.idl is located
> at /usr/share/idl/bonobo-2.0/Bonobo.idl.
> 
> Add these to your configure.ac:
> LIBBONOBO_IDLDIR="`$PKG_CONFIG libbonobo-2.0 --variable=idldir`"
> AC_SUBST(LIBBONOBO_IDLDIR)
> BONOBO_ACTIVATION_IDLDIR="`$PKG_CONFIG bonobo-activation-2.0 --
> variable=idldir`"
> AC_SUBST(BONOBO_ACTIVATION_IDLDIR)
> 
> and this to your ORBIT_IDL line in Makefile.am:
> -I$(LIBBONOBO_IDLDIR) -I$(BONOBO_ACTIVATION_IDLDIR)

Interesting.  On Debian, the bonobo package provides
/usr/share/idl/Bonobo.idl, and the libbonobo2-common package provides
/usr/share/idl/bonobo-2.0/Bonobo.idl, and the two files seem to be
slightly different.  I hadn't realized that the files Rhythmbox.idl
#includes could be in a different directory.

Anyway, here's a patch which ought to fix the problem.  It should be
equivalent to yours, except that I make a single ORBIT_INCLUDES variable
to contain the two -I directories.  (Wasn't the goal of pkg-config that
we wouldn't have to build these sorts of include paths ourselves?)  If
you could confirm that this patch solves the problem, I'll release a
version 0.1.2 with it.
--- orig/configure.ac
+++ mod/configure.ac
@@ -22,6 +22,11 @@
 RB_IDLDIR="`$PKG_CONFIG --variable=idldir rhythmbox`"
 AC_SUBST(RB_IDLDIR)
 
+LIBBONOBO_IDLDIR="`$PKG_CONFIG --variable=idldir libbonobo-2.0`"
+BONOBO_ACTIVATION_IDLDIR="`$PKG_CONFIG --variable=idldir bonobo-activation-2.0`"
+ORBIT_INCLUDES="-I$LIBBONOBO_IDLDIR -I$BONOBO_ACTIVATION_IDLDIR"
+AC_SUBST(ORBIT_INCLUDES)
+
 CFLAGS="-Wall -W -Wno-unused -Werror -g -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED $RB_APPLET_DEP_CFLAGS"
 LIBS="$RB_APPLET_DEP_LIBS"
 
--- orig/src/Makefile.am
+++ mod/src/Makefile.am
@@ -15,7 +15,7 @@
 nodist_noinst_HEADERS = $(rb_interface_h)
 
 $(rb_interface_c) $(rb_interface_h): $(RB_IDLDIR)/Rhythmbox.idl
-	$(ORBIT_IDL) --debug=0 --noskels $(RB_IDLDIR)/Rhythmbox.idl
+	$(ORBIT_IDL) --debug=0 --noskels $(ORBIT_INCLUDES) $(RB_IDLDIR)/Rhythmbox.idl
 
 CLEANFILES = $(rb_interface_c) $(rb_interface_h)
 

Attachment: signature.asc
Description: Digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]