Hi, On Tue, 2005-04-26 at 23:04 +1000, James Livingston wrote: > I think I've pretty much got everything apart from polish done on the > playlist criteria - so if you see anything like bugs, typos, defaults > that could have better values, etc. let me know. Does the filtering by Artist, Title, Genre or Album work for you? I get a segfault everytime I select one of those from the options menu. The attached patch fixes it here. The Rating criteria has some rounding problems. Some examples: 1. Selecting 'Rating equals 3' creates an empty playlist. 2. Selecting 'Rating is at least 4' shows all 5 star songs but not all 4 star songs 3. Selecting 'Rating is less than 3' still adds a lot of 3 star songs to the playlist. Some thoughts about usability: At the moment, it is not possible to remove the last criteria in the list because there's no remove button. Maybe the Add button can be moved up beside the top label and a remove button could be placed beside _each_ criteria similar to how it works in evolution's filter editor. And finally: The 'First Seen' criteria is drop-dead gorgeous! :-) Just a small remark (I know I'm getting on your nerves, sorry). Selecting 'First seen in the last 1 week' and limiting the list to 20 songs, I would expect to get the latest 20 songs which were added to the library. Currently, more or less arbitrary songs end up in the list. If this is something that will be solved with your work on the sorting, just forget it for now. -- so long, oliver Public GPG Key: http://www.core-dump.info/olemke-public.asc Fingerprint: 2389 0B2C 1AA8 4E3E D5AD 3B72 00DB ABDC 73ED C558
--- orig/widgets/rb-query-creator.c
+++ mod/widgets/rb-query-creator.c
@@ -619,6 +619,10 @@
case RHYTHMDB_PROP_ARTIST:
case RHYTHMDB_PROP_ALBUM:
case RHYTHMDB_PROP_GENRE:
+ case RHYTHMDB_PROP_TITLE_FOLDED:
+ case RHYTHMDB_PROP_ARTIST_FOLDED:
+ case RHYTHMDB_PROP_ALBUM_FOLDED:
+ case RHYTHMDB_PROP_GENRE_FOLDED:
options = string_criteria_options;
if (length)
*length = G_N_ELEMENTS (string_criteria_options);
@@ -665,10 +669,10 @@
*constrain = TRUE;
switch (prop) {
- case RHYTHMDB_PROP_TITLE_FOLDED:
- case RHYTHMDB_PROP_ARTIST_FOLDED:
- case RHYTHMDB_PROP_ALBUM_FOLDED:
- case RHYTHMDB_PROP_GENRE_FOLDED:
+ case RHYTHMDB_PROP_TITLE:
+ case RHYTHMDB_PROP_ARTIST:
+ case RHYTHMDB_PROP_ALBUM:
+ case RHYTHMDB_PROP_GENRE:
widget = gtk_entry_new ();
break;
Attachment:
signature.asc
Description: This is a digitally signed message part