[Rhythmbox-devel] Cover search

[Tristan Tarrant <tristan tarrant dataforte net>]

Hi all,
I have compiled Oliver Lemke's rhythmbox-merge branch and I must say I rather like the improvements.

I attach a patch against Oliver's tree which adds the glade files for the cover search to the Makefile.am so that they are installed correctly and also to disable the confirmation box which appears after a cover has been selected and saved to disk (if everything was ok I don't want to know

 )
Also I believe the cover search should do an automatic lookup immediately without the user having to click on the search button.

Tristan

Attachment: smiley-3.png
Description: PNG image

--- data/glade/Makefile.am.orig	2005-04-28 10:04:48.416900000 +0200
+++ data/glade/Makefile.am	2005-04-28 10:06:03.907423696 +0200
@@ -1,15 +1,18 @@
 ## arch-tag: Automake rules for glade XML files
 
-glade_DATA =	general-prefs.glade	  	\
+glade_DATA =	cover-prefs.glade		\
+		cover-progress.glade		\
+		cover-select.glade		\
+		create-playlist.glade		\
+		druid.glade			\
+		general-prefs.glade	  	\
 		library-prefs.glade	  	\
+		load-failure.glade		\
 		song-info.glade			\
 		song-info-multiple.glade	\
-		load-failure.glade		\
+		recorder.glade			\
 		station-new.glade		\
 		station-properties.glade	\
-		create-playlist.glade		\
-		druid.glade			\
-		recorder.glade			\
 		uri.glade
 
 gladedir = $(pkgdatadir)/glade
--- shell/rb-shell-coverselect.c.orig	2005-04-28 10:08:55.000000000 +0200
+++ shell/rb-shell-coverselect.c	2005-04-28 10:09:34.000000000 +0200
@@ -444,13 +444,6 @@
 
 	switch (result) {
 	case GNOME_VFS_OK:
-		dialog = gtk_message_dialog_new(NULL,
-						GTK_DIALOG_MODAL,
-						GTK_MESSAGE_INFO,
-						GTK_BUTTONS_OK,
-						"File successfully saved");
-		gtk_dialog_run(GTK_DIALOG(dialog));
-		gtk_widget_destroy(dialog);
 		break;
 	case GNOME_VFS_ERROR_FILE_EXISTS:
 		break;