Re: [Rhythmbox-devel] [patch] libsoup related bug in audioscrobbler plugin

[Bastien Nocera <hadess hadess net>]

On Sat, 2008-03-22 at 00:13 -0300, Claudio Saavedra wrote:
> Hi all,
> 
> I found out that when rb saves songs to AS queue, later they get
> scrobbled in a URI fashion encoding, like this:
> 
>   Jerry%20Cantrell – Breaks%20my%20Back
> 
> instead of
> 
>   Jerry Cantrell – Breaks my Back
> 
> I did some research and found out that this is due to some changes in
> the libsoup API during the 2.3 cycle:
> 
> 2008-01-14  Dan Winship  <danw gnome org>
> 
> 	[...]
> 	(soup_uri_decode, soup_uri_normalize): Change these to return the
> 	decoded/normalized string rather than modifying it in place.
> 	[...]
> 
> So, I cooked a patch to fix this, while keeping compatibility with
> libsoup 2.2. Patch is attached. It is worth noting that this also caused
> some memory leaks.
> 
> Ok to commit?

There's alrady a patch in bugzilla:
http://bugzilla.gnome.org/show_bug.cgi?id=509701

Cheers