EggRecent breakage



Hi,

At the beginning of the month I committed a patch to EggRecent (with
snorp's approval) which added a <Count> element to the file, and
incremented this value every time the same URI was added.  This allowed
the recent files list to be sorted on most- or least-frequently used,
instead of recently.

However, it turns out that applications using a version off EggRecent
before this commit not only trash the <Count> element (expected
behaviour of course), but also spew errors to stderr when it finds the
<Count> elements:

** (eog:7503): CRITICAL **: file egg-recent-model.c: line 328 (peek_state): assertion `info->states != NULL' failed

** (eog:7503): CRITICAL **: file egg-recent-model.c: line 320 (pop_state): assertion `info->states != NULL' failed

Ignoring the fact that the <Count> element is not in the specification
(I honestly can't remember what James said about this, but I think it
was along the lines of "only egg and OO.o use the spec, so we can it
shortly"), should I:

a) revert the changes to libegg, removing the <Count> element, and
   ruining my cunning applet, or
b) start a mass update of libegg in the core modules

Obviously the EggRecent parser should be made more lenient no matter
what choice is taken.

Ross
-- 
Ross Burton                                 mail: ross burtonini com
                                          jabber: ross burtonini com
                                     www: http://www.burtonini.com./
 PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]