[PATCH] help browser



I've fixed the behavior of the help-browser from what was happening in
gnome bug #116.  I am not familiar with the help browser enough to know
whether this patch is right, or if it will mess other things up.  Anyway,
if someone can let me know if it is right/wrong I'll commit it to cvs.

Thanks,
Jacob Berkman

-- 
"Me fail English?  That's unpossible!" - R. Wiggam
Index: help-browser-impl.c
===================================================================
RCS file: /cvs/gnome/gnome-core/help-browser/help-browser-impl.c,v
retrieving revision 1.4
diff -u -r1.4 help-browser-impl.c
--- help-browser-impl.c	1998/11/26 14:33:08	1.4
+++ help-browser-impl.c	1999/04/10 20:18:28
@@ -149,11 +149,14 @@
     
   CORBA_exception_init(&ev);
   servant = g_hash_table_lookup(win_servant_hash, win);
-  g_hash_table_remove(win_servant_hash, win);
-  fprintf(stderr,"getting servant data %p from window %p\n", servant, win);
+  if (servant) 
+    {
+      g_hash_table_remove(win_servant_hash, win);
+      fprintf(stderr,"getting servant data %p from window %p\n", servant, win);
   
-  oid     = PortableServer_POA_servant_to_id(servant->poa, servant, &ev);
+      oid     = PortableServer_POA_servant_to_id(servant->poa, servant, &ev);
     
-  PortableServer_POA_deactivate_object(servant->poa, oid, &ev);
-  impl_help_browser_simple_browser__destroy(servant, &ev);
+      PortableServer_POA_deactivate_object(servant->poa, oid, &ev);
+      impl_help_browser_simple_browser__destroy(servant, &ev);
+    }
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]