Re: new gnome-session logout

[Owen Taylor <otaylor redhat com>]

Jacob Berkman <jberkman@andrew.cmu.edu> writes:

> Hi,
> 
> After updating to the newer gnome-session (with the RH6 patches merged in)
> I immediately wanted to save the session by default, but be able at "end
> session time" to not save the session.
> 
> Anyway here is a little diff that does what I want.  I can commit it if
> you like, or just leave it in my local tree forever.

I have to disagree with Tom and say that I don't like this
patch. When you are automatically saving the sesssion,
the session will be saved fairly frequently and at times
that are opaque to the user. (IIRC, generally, the
session is saved when a program is added or removed
from the session.)

So, putting a button there which allows the user to
"not save the session" is just a tease and the user
really has no idea at all what he will get when 
if he unchecks that button.

Most users would probably think that it means that the
session will be reverted back to the starting point
when they log back in, which is not even close to right.

In fact, even I have a hard time understanding what
that button would do at... my best guess is that if you
unchecked it, you would get the same set of programs
that you have at logout time, but some indeterminate
amount of setup data for those applications would be
reverted.

Regards,
                                        Owen

> Index: logout.c
> ===================================================================
> RCS file: /cvs/gnome/gnome-core/gsm/logout.c,v
> retrieving revision 1.1
> diff -u -r1.1 logout.c
> --- logout.c	1999/08/01 22:06:53	1.1
> +++ logout.c	1999/08/02 03:33:01
> @@ -218,14 +218,12 @@
>    gtk_container_set_border_width (GTK_CONTAINER (GNOME_DIALOG (box)->vbox),
>  				  GNOME_PAD);
>  
> -  if (trashing)
> -    {
> -      toggle_button = gtk_check_button_new_with_label (_("Save current setup"));
> -      gtk_widget_show (toggle_button);
> -      gtk_box_pack_start (GTK_BOX (GNOME_DIALOG (box)->vbox),
> -			  toggle_button,
> -			  FALSE, TRUE, 0);
> -    }
> +  toggle_button = gtk_check_button_new_with_label (_("Save current setup"));
> +  gtk_toggle_button_set_active (toggle_button, !trashing);
> +  gtk_widget_show (toggle_button);
> +  gtk_box_pack_start (GTK_BOX (GNOME_DIALOG (box)->vbox),
> +		      toggle_button,
> +		      FALSE, TRUE, 0);
>  
>    ask = gtk_check_button_new_with_label (_("Ask next time"));
>    gtk_widget_show (ask);
> 
> 
> 
> 
> -- 
> To unsubscribe: mail gnome-devel-list-request@gnome.org with "unsubscribe"
> as the Subject.