[peter.wainwright@nrpb.org.uk: Re: gnome-core-1.1.9: panel eating memory]

[Peter Wainwright <prw wainpr demon co uk>]

I'm sending this again because I used a different From: address last time so it
has been held pending moderation.


On Fri, 28 Apr 2000 09:42:10 Peter Wainwright wrote:
This is a memory leak in the panel, which has been triggered by a bug which
shows
up when drawing icons on a panel with a pixmap background. I have reported
this to the gnome bug system. The patch is as follows (this should also let
your
transparent icons draw correctly on a pixmap background):
===============
diff -U4 -r gnome-core-old/panel/rgb-stuff.c gnome-core/panel/rgb-stuff.c
--- gnome-core-old/panel/rgb-stuff.c	Fri Apr 14 11:43:14 2000
+++ gnome-core/panel/rgb-stuff.c	Fri Apr 28 08:50:29 2000
@@ -30,8 +30,9 @@
 	gint rowstride;
 	art_u8 r, g, b;
 	gint xx, yy;
 	int width, height;
+	GdkPixbuf *pb;
 
 	g_return_val_if_fail (window != NULL, NULL);
 	
 	gdk_window_get_size(window, &width, &height);
@@ -110,10 +111,12 @@
 	}
 
 	gdk_image_destroy(image);
 
-	return gdk_pixbuf_new_from_data(buff, GDK_COLORSPACE_RGB, FALSE, 24,
-					width, height, rowstride, NULL, NULL);
+	pb = gdk_pixbuf_new_from_data(buff, GDK_COLORSPACE_RGB, FALSE, 8,
+				      width, height, rowstride, NULL, NULL);
+	if (!pb) g_free(buff);
+	return pb;
 }
 
 void
 combine_rgb_rgba(guchar *dest, int dx, int dy, int dw, int dh, int drs,
===============



On Fri, 28 Apr 2000 00:33:18 Geoff Reedy wrote:
> 
> On Thu, Apr 27, 2000 at 06:39:41PM -0400, Scott Barnes <reeve@ductape.net>
said
> > 
> > This isn't the panel, this is imlib's problem.  I know because I tracked
it
down
> > and reported it myself using MemProf and Bug-Buddy.  The problem is that
> > imlib's xpm loader doesn't unload properly.
> > 
> 
> So this only happens when you are using a gtk theme with xpms in it?
> Does anyone know then, why it just started happening in gnome-core 1.1.9,
> because I had no problem with 1.1.8?  Has it got to do with gdk-pixbuf?
> 
> 
> -- 
> Geoffrey Reedy                   Student Network System Administrator
> vader21@imsa.edu                    Illinois Math and Science Academy
> 
> "Unix-to-Unix Copy Program;" said PDP-1.  "You will never find a more
> wretched hive of bugs and flamers.  We must be cautious."
> 				-- DECWARS
> 
> _______________________________________________
> gnome-devel-list mailing list
> gnome-devel-list@gnome.org
> http://mail.gnome.org/mailman/listinfo/gnome-devel-list