RE: Trivial patches on b.g.o covers dust.

[Owen Taylor <otaylor redhat com>]

On Tue, 2003-04-22 at 14:15, Ali Akcaagac wrote:
> On Tue, 2003-04-22 at 17:48, Kjartan Maraas wrote:
> > Like for all things in universe resources are not infinite. If you think
> > the bugsquad needs to work faster, you need to join in the fun :-)
> 
> Well I am willing to go through the list of bugs one by one as I did now
> and report to the mailinglists if you wish.
> 
> > > gtk+ and libgnomeui toolbar fixes
> > > ---------------------------------
> > This is pending Owen's feedback I guess
> > http://bugzilla.gnome.org/show_bug.cgi?id=106336
> 
> Yes, would be good to have that one in CVS HEAD. It doesn't hurt anyways
> because it will get replaced by libegg toolbar anyways one day so you
> don't trash anything for future implementations. you only add 4 chars in
> the toolbarcode and change the style in the object to GTK_STYLE_NONE or
> something. What takes so long to have that one in CVS ? It's obvious
> that it solves the problem.

Roughly speaking, I'd class patches for GTK+ into three categories:

 1) Major patches that are going to need several passes back
    and forth and evolution before they are ready to commit.

 2) Trivial fixes that are obviously correct

 3) Simple patches that have non-obvious side-effects and take
    some consideration.

I try to get to patches in roughly the order above.

There are several reasons why this fits into 3):

 - The change for the drawing is clearly correct; and I want
   to put it into HEAD. However, some people consider it to make
   things _worse_ since it makes the case of drawing double bevels
   more obvious. So, it's not clear if it should go into stable.
 
 - Any change to default values for properties or style properties 
   is minor incompatible API breakage, so a) takes careful consideration
   b) Cannot be done on stable.

 - There is a big toolbar change coming with the integration of
   EggToolbar. It's just a waste to spend time doing small fiddling with
   GtkToolbar in HEAD prior to pulling a much modified version
   of the toolbar to libegg which would overwrite those changes.

Regards,
                                   Owen