Re: Several compile issues

[Gregory McLean <gregm comstar net>]

> Hi everyone.
> I'm trying to get a clean compile of most of the CVS tree.
> I found several small issues.
> 
 ------------------------------------------------------------------------------
-
> 
> 'form-maker':
> i got the following error:
> gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/X11R6/include -I/opt/GNOME/lib/glib/include -I/opt/GNOME/include -I..  -g -O2 -c main.c 
> main.c: In function `main':                                                     
> main.c:52: `TEMPLATE_CONF' undeclared (first use this function)                 
> main.c:52: (Each undeclared identifier is reported only once                    
> main.c:52: for each function it appears in.)                                    
> make[2]: *** [main.o] Error 1          
> This results from the fact main.c includes "paths.h", which is *not* present in the
> current dir because it must be built from paths.h.in, before doing so make finds
> /usr/include/paths.h (standard in my debian hamm distribution) and uses that 
> instead, whence the error.                                         
> I also changed the (IMHO sucking) default for the template dirs/

I have corrected this in the cvs tree.

> ========================================
> diff -ru GNOME/form-maker/app/Makefile.am GNOME.build/form-maker/app/Makefile.am                                                                           
> --- GNOME/form-maker/app/Makefile.am    Sun Oct 11 23:08:15 1998                                                                                           
> +++ GNOME.build/form-maker/app/Makefile.am      Fri Oct 16 18:53:40 1998                                                                                   
> @@ -36,7 +36,7 @@                                                                                                                                          
>             < $(srcdir)/paths.h.in >paths.h.tmp \                                                                                                          
>             && mv -f paths.h.tmp paths.h                                                                                                                   
>                                                                                                                                                            
> -BUILT_SOURCES = formyacc.h                                                                                                                                
> +BUILT_SOURCES = formyacc.c formyacc.h paths.h                                                                                                             
>                                                                                                                                                            
>  INCLUDES = \                                                                                                                                              
>         $(X_CFLAGS)     \                                                                                                                                  
> diff -ru GNOME/form-maker/configure.in GNOME.build/form-maker/configure.in                                                                                 
> --- GNOME/form-maker/configure.in       Sun Oct 11 23:08:15 1998                                                                                           
> +++ GNOME.build/form-maker/configure.in Fri Oct 16 15:45:36 1998                                                                                           
> @@ -27,8 +27,8 @@                                                                                                                                          
>  fi)                                                                                                                                                       
>                                                                                                                                                            
>  dnl Possibly change the default template dir.                                                                                                             
> -templatedir="/mnt/engineering/templates"                                                                                                                  
> -AC_ARG_ENABLE(templatedir, [  --enable-templatedir=DIR    Change the default templatedir from /mnt/engineering/templates to DIR],                         
> +templatedir="$prefix/var//templates"                                                                                                                      
> +AC_ARG_ENABLE(templatedir, [  --enable-templatedir=DIR    Change the default templatedir from $prefix/share/templates to DIR],                            
>  if eval "test x$enable_templatedir != x"; then                                                                                                            
>    if eval "test x$enable_templatedir != xyes"; then                                                                                                       
>      templatedir=$enable_templatedir                                                                                                                       
I put some defines in for this, the 'sucking' default is cause I'm lazy :)
Now all you have to do is change a few commented lines and poof.


> I do not have much time in my hands, so I will have to ask the various 
> developers if the specific patch is acceptable and/or to find a solution.
> 
> Is this of any interest?

I'm always interested in patches that make the monster that lives in CVS easier
to build. And as you can see if they are reasonable to stuff I directly am
responsible for I will go ahead and make the changes. Other stuff I have to
look over with greater care as peoples toes are delicate :)

> 
> 
> 
> Best Regards
> 
> Mauro Condarelli

Thanks!
-- Greg
> 
> 
> -- 
>          To unsubscribe: mail gnome-list-request@gnome.org with 
>                        "unsubscribe" as the Subject.
> 

-- 
Gregory McLean             |
Engineer                   | Linux renders ships, NT renders ships useless
ComStar Communications Inc.|