Re: [gnome-network]PATCHES for bug 114826

[Rodrigo Moya <rodrigo gnome-db org>]

On Tue, 2003-12-09 at 19:19, Emil Soleyman-Zomalan wrote:
> 
> Hi Rodrigo,
> 
> Please excuse the mistakes. I'm trying to learn GNOME's conventions and
> APIs as I go on.
> 
no problem at all, it's nice that you send patches, and sending them to
the list is for having them reviewed, so really, just keep sending
patches :-)

> With this patch I've done the following:
> 
> [1] I took a look at the #includes and I've re-jiggered them to fit 
>     better with the functions we are using.
> 
>     ADDED
>     <gtk/gtklabel.h> 		for gtk_label_set_use_markup
>     <gtk/gtkmessagedialog.h>	for gtk_message_dialog_new
>     <libgnome/gnome-help.h>	for gnome_help_display
>     <libgnomeui/gnome-window-icon.h>	for gnome_window_icon_set_
> 					default_from_file
> 
> [2] All strings are now prefixed with _(" and postfixed with ") so 
>     that they are translatable.
> 
> [3] Don't leak msgerror.
> 
> [4] Don't allocate memory for 'title'.
>
this one works great and has now been applied to CVS,

thanks