Re: Antw: Re: [gnome-network]Patch for GNOME Remote Shell

[Mason Kidd <mason_kidd mrkidd com>]

Yep, that patch applied successfully.  This is awesome, nice work,
exactly the functionality this program needed.  WIll save me a lot of
typing!

Couple of comments:
- The 'Profiles' heading doesn't match the font of the other headings. 
This might be because it is using a <span weight=bold> tagset, whereas
the other labels are using just a <bold> tagset.
- The 'Profiles' heading is the only area with a frame, and this throws
off the look a little.  I think that either all four areas should have
frames, or none of them should (I'd vote for none).
- Double-clicking on a Profile should Apply+Connect. 
- The .gnome-remote-shell.profiles file should probably be stored in the
.gnome2/ directory.  I think you can use g_build_filename
(g_get_home_dir (), GNOME_DOT_GNOME,  "gnome-remote-shell.profiles",
NULL);  (gnome-remote-desktop should probably be changed to do this as
well).
- The .gnome-remote-shell.profiles file wasn't being read on startup
because the file was created with no permissions.  You might want to use
gnome-vfs utility functions for creating this file.

I'll try and work on some of this if I get a chance.

Thanks!!
Mason Kidd

On Sun, 2004-01-11 at 10:12, Ulrich Neumann wrote:
> Hi Mason,
> 
> i've attached the file again, and i've attached the new glade file
> itself (for the case if the patch doesn't work). I hope this time you're
> successful.
> 
> Ulrich
> 
> 
> >>> Mason Kidd <mason_kidd mrkidd com> 11.01.04 6.49 >>>
> The file patch2.diff did not apply cleanly for me (using anon cvs
> updated at about 5 minutes ago).  The output from patch is:
> patching file gnome-remote-shell.glade
> Hunk #4 FAILED at 770.
> Hunk #5 succeeded at 986 (offset -12 lines).
> 1 out of 5 hunks FAILED -- saving rejects to file
> gnome-remote-shell.glade.rej
> 
> Attached is the rejects file.  
> 
> Mason Kidd
> 
> On Sat, 2004-01-10 at 19:01, Ulrich Neumann wrote:
> > Hello,
> > 
> > attached are two patch files and a new file that changes/adds the
> > following to GNOME Remote Shell:
> > - Added gnome-remote-shell.h that holds prototypes and definitions.
> > - Some UI corrections
> > - Added profiles
> > - Added functionality to clear user and/or host history
> > - Added support for command line parameters -l and -h
> > - Added support to pass a preset username with -l to the window:
> > Esample: gnome-remote-shell -l remoteuser
> > - These Patches take care of BUG# 125705 and BUG# 130674
> > 
> > You need all files in order to use all of the above. I hope i'm early
> > enough that these patches can be added to the next release of Gnome,
> > because UI freeze will be on monday.
> > 
> > Ulrich
>