Re: About dialog api

[Owen Taylor <otaylor redhat com>]

On Sat, 2003-04-26 at 20:06, Matthias Clasen wrote:
> I have put an updated implementation into
> http://bugzilla.gnome.org/show_bug.cgi?id=109435
> I have added "website" and "website_label" properties (to add a link
> to the about dialog), added an optional "artists" page to the credits 
> dialog and implemented autolinkification for emails and urls in the
> credits dialog. Sending emails and showing urls is "done" by emitting
> signals on the about dialog. This has the downside that the _show()
> function must take the signal handlers as arguments: 
> 
> void       gtk_about_dialog_show     (GtkWindow    *parent,
> 				      GCallback     send_email_cb,
> 				      GCallback     show_url_cb,
> 				      const gchar *first_property_name,
> 				      ...);
> 
> The autolinkification is suppressed if no handlers are connected.

Can I suggest that much better would be:

 gtk_about_dialog_set_link_hooks ()

So that libgnomeui, say, could hook them up to the GNOME functions, and
if an app wants to do the same it could do so. I'd use real function
prototypes rather than GCallback too; also you want to pass in the 
GtkAboutDialog so that the callback can show the web browser on
the right screen/display.

Regards,
                                             Owen