Re: [PATCH] GtkFileChooserDefault: Add/Remove bookmark button tweaking

[Christian Neumair <chris gnome-de org>]

On Tue, 2004-04-06 at 12:35 +0100, Calum Benson wrote:
> On Mon, 2004-04-05 at 03:04, Jonathan Blandford wrote:
> 
> > I don't know if that applies here.  Seth seemed to like add/remove when
> > we designed the file selector.  You'll have to run it by him here.
> 
> Yeah, that rule is really only supposed to apply to the primary buttons
> in a window, i.e. the ones along the bottom that (more often than not)
> close it.  Elsewhere the natural/task order should normally be used, so
> here Add-Remove seems like the right order to me.

I don't second that emotion at all. I changed this order it because it
seemed to be natural to me, and I still think so. When visually grepping
through an interface like a treeview that has buttons below it, my eyes
behave very much like with the dialog itself. Therefore the button in
the right down edge should represent the more obvious action which is
adding a bookmark. You call add|remove the "natural/task order" which
makes me think that you still don't consider the rule to place the most
obvious on the right hand side natural for widgets that are not dialogs.
This is heavily inconsistent. Buttons inside a dialog's action area
align with the widget above them. The same is valid for this treeview:
Its add/remove buttons align with the treeview itself. I fear that not
applying our dialog rules consequently throughout dialogs will extremely
confuse users.

regs,
 Chris