Re: GIO API review

[Carlos Garnacho <carlos imendio com>]

Hi all!,

On mar, 2007-12-11 at 17:48 +0100, Michael Natterer wrote:
> Hey everybody,
> 
> We've been doing a GIO API review in the last couple of days and
> here is the list of comments and issues we've come up with:
> 

I Just wanted to raise another concern I have. Besides defining enums
containing flags like GFileBlahFlags in gio, values inside these also
are defined like G_FILE_BLAH_FLAGS_FOOBAR (note the "_FLAGS_" in the
definition)

I don't think the values should specify too whether they're a flag, as
the enum is already defined as a set of these, that way it'd also
conform more to glib and gtk+ style.

Regards,
   Carlos