Re: Steps to get to GTK+ 3.0

[Kristian Rietveld <kris imendio com>]

Hey Matthias,

On Wed, Jun 04, 2008 at 12:20:49PM -0400, Matthias Clasen wrote:
> I spent some time looking through the git history. Here are a few
> notes I penned down while doing so:
> 
> - docs are missing
>   - for GSEAL itself,
>   - for GSEAL_ENABLE

IIRC the GSEAL macro is supposed to end up in glib, it was added in
gdkconfig.h here so we only had to work with a gtk+ repo for now.  Once
this will land in glib we will make sure there are proper docs.

>   - for new properties such as the ones introduced in GtkAccelGroup
>   - for new accessors such as the ones introduced in GtkDialog

I am sure these will be added during review before the merge.


> - Minor thing, but this looks slightly odd to me: guint GSEAL
> (show_tabs          : 1);
>   I guess I would have expected guint GSEAL (show_tabs) : 1;

We started out with the former format and the others followed.  I just
spoke with Tim and although both formats will work, the latter (with the
colon outside the parens) is technically preferable.  We will be moving
all files to use the latter format over the weekend.

> - What about /*< private >*/ ? Do we need these markers anymore, now
> that everything is private ?

In essence all fields will remain to be public/private in the 2.x series
unless you turn on GSEAL_ENABLE.  I think we should leave the markers
there in 2.x.  Once the structures will be moved to private
headers/source files the markers can be removed (together with the GSEAL
things of course).

> - Why is GtkCellRenderer::editing writable ? that doesn't make
> intuitive sense to me...

Good point :)  Fixed it.


thanks,

-kris.