Re: Small glib 2.28 patch for Win32

[Alexander Larsson <alexl redhat com>]

On Mon, 2011-04-04 at 12:34 +0200, Kean Johnston wrote:
> On 4/4/2011 10:25 AM, Alexander Larsson wrote:
> > On Mon, 2011-04-04 at 08:30 +0200, Kean Johnston wrote:
> >> $TITLE says it all
> >
> > I can see that its a patch, and i can sort of guess what it does, but a
> > bit more description would be nice.
> * Only include unistd.h if the system has it

This was already fixed.

> * Use GLocalFileStat rather than struct stat as the first is platform
>    independent and the second isn't. Also on Windows use _fstati64
>    rather than fstat.
> 
> > +#if !defined(G_OS_WIN32) || !defined(_MSC_VER)
> >   #include<unistd.h>
> > +#endif

I pushed this part to master.

> > Why isn't this also using HAVE_UNISTD_H
> Because it doesn't include config.h and since it was code that was sort of 
> living off to the side and I didn't know if it would be appropriate to 
> introduce a dependency on autoconf/configure/config.h, I did it a more
> portable way.

Yeah, this code seems shared between various modules.
Ryan? What is your prefered way to fix this?

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl redhat com            alexander larsson gmail com 
He's a deeply religious drug-addicted librarian haunted by an iconic dead 
American confidante She's a wealthy communist schoolgirl with the soul of a 
mighty warrior. They fight crime!