Re: [Bug 91344] New - Toolbar icon buttons should have minimum width

Michael Meeks <michael ximian com> writes:

> Hi Guys,
> 	I'd like to fix this bug; but the problem is that if I do this - since
> we split the 'Forward/Backward' popdowns into separate control widgets
> for reasons I don't understand; why did we do that ?
> 	In order to fix this I'd need to switch them back into the Controls -
> and fix the parent backround issue in-proc. So I'll take a look at this,
> unless someone screams,

I haven't looked at the code recently, but their were all sorts
of problems with having them controls beyond the background ...
the code had to completely break any abstraction that the "control"
interface provided had to propagate things like orientation between
toolbar and children. 

It would have much simpler, and even cleaner, to have simply done
some widget heirarchy walking to find the button that Bonobo
had created.

In any case... I seem to remember the separation being done for 
usability reasons, though I'm sure someone else could comment
better on that.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]