Re: [PATCH] Bug#153055 - user name in "Connect to Server" dialog box is not escaped

[Alexander Larsson <alexl redhat com>]

On Sun, 2004-09-26 at 23:59 -0400, Michael Henson wrote:
> Attached is a patch which should properly escape the various components
> of the uri generated by the "Connect to Server" dialog.
> 
> While I believe this patch fixes the issue from nautilus's perspective
> there still does seem to be an issue in gnome-vfs in that while I will
> properly extract the username from the uri string, it does not look like
> it properly decodes it, before possibly re-encoding it again (tested
> against an http source).
> 
> I will have to look at gnome-vfs more closely to determine if this is
> indeed the problem, but figured I would throw the patch out there in the
> meantime.

Username escaping is indeed a problem in many many places in gnome-vfs
and nautilus. Making this work everywhere will require lots of code
inspection and making sure everything handles this in the correct way.

The path escaping looks strange. Why can't you just use
gnome_vfs_escape_path_string()?

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a scrappy ninja inventor who dotes on his loving old ma. She's a radical 
French-Canadian politician who can talk to animals. They fight crime!