Re: [PATCH] Bug#153055 - user name in "Connect to Server" dialog box is not escaped

[Michael Henson <mike axl net>]

On Mon, 2004-09-27 at 17:17 +0200, Alexander Larsson wrote:
> On Sun, 2004-09-26 at 23:59 -0400, Michael Henson wrote:
> > Attached is a patch which should properly escape the various components
> > of the uri generated by the "Connect to Server" dialog.
> > 
> 
> Username escaping is indeed a problem in many many places in gnome-vfs
> and nautilus. Making this work everywhere will require lots of code
> inspection and making sure everything handles this in the correct way.
> 

Yeah I agree, there are many place where even the display of the escaped
urls are also not quite as nice as one would like as well.

> The path escaping looks strange. Why can't you just use
> gnome_vfs_escape_path_string()?
> 

Ah, I completely missed this function. I'll rewrite the patch to use it
later on tonight and update the bug.

-- Michael